Skip to content

Bump cecil version #1515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 9, 2020
Merged

Bump cecil version #1515

merged 3 commits into from
Oct 9, 2020

Conversation

marek-safar
Copy link
Contributor

No description provided.

@marek-safar marek-safar reopened this Sep 26, 2020
@marek-safar
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

vitek-karas
vitek-karas reviewed Oct 8, 2020
View reviewed changes
@vitek-karas
Copy link
Member

The Windows tests are broken by dotnet/cecil@191f9fc
When we rewrite a method's body to a throw we remove all debug scope information and all sequence points. When the assembly is written out the new behavior will force-read symbols from the original PDB for the method, but those symbols don't match the method body anymore.
The failure is because the native PDB writer validates this and fails. (I guess managed PDB writer doesn't care a produces broken PDB).

@vitek-karas
Copy link
Member

Actually this is a known issue now: jbevain/cecil#694

@marek-safar
Copy link
Contributor Author

@vitek-karas I reverted that change and still the same problem :-(

@vitek-karas
Copy link
Member

That's because linker master still uses package reference to Mono.Cecil - so the fixes you picked up into the submodule don't apply. We will either have to wait for the fix to make it into cecil's master and eventually package, or switch fully to rely on the submodule.

@marek-safar
Copy link
Contributor Author

@vitek-karas yeah, I completely forgot about that

marek-safar and others added 2 commits October 9, 2020 12:54
@marek-safar
Bump cecil version
52fd372
@sbomer @marek-safar
Build against Cecil submodule (dotnet#1477)
a7c8f6a 
* Build against Cecil submodule

* Depend on official cecil version

With this change, the nuspec of the ref assembly package will
list cecil verision 0.11.2 as a dependency (instead of 5.0.0-rc*).
This allows consumers of the ref package to use the publicly
released cecil.
@vitek-karas
Copy link
Member

There's a formatting bug in the master - I just added a fix into this PR as it was faster...
Yesterday I saw build errors when building with the submodule on Windows - but apparently something in this PR fixes that - no build errors for me anymore (apart from the formatting fix which shows up as an error).

@vitek-karas
Copy link
Member

/cc @sbomer for when he gets back to take a quick look.

@vitek-karas vitek-karas merged commit 41078a0 into dotnet:master Oct 9, 2020
sbomer added a commit to sbomer/linker that referenced this pull request Jul 27, 2021
@sbomer
Bump cecil package version
1b7f1ac 
The submodule update in dotnet#2156
incremented the cecil version, but we were still using 0.11.3 as the version
in our package graph. See dotnet#1515 for more
context on how this is set up.

Fixes dotnet#2173
@sbomer sbomer mentioned this pull request Jul 27, 2021
Merged
sbomer added a commit that referenced this pull request Jul 28, 2021
@sbomer
Bump cecil package version (#2174)
0cb9250 
* Bump cecil package version

The submodule update in #2156
incremented the cecil version, but we were still using 0.11.3 as the version
in our package graph. See #1515 for more
context on how this is set up.

Fixes #2173

* Remove unnecessary cast
agocke pushed a commit to dotnet/runtime that referenced this pull request Nov 16, 2022
@marek-safar
Bump cecil version (dotnet/linker#1515)
76db5e2 
With this change, the nuspec of the ref assembly package will
list cecil verision 0.11.2 as a dependency (instead of 5.0.0-rc*).
This allows consumers of the ref package to use the publicly
released cecil.

Co-authored-by: Sven Boemer <[email protected]>
Co-authored-by: vitek-karas <[email protected]>

Commit migrated from dotnet/linker@41078a0
agocke pushed a commit to dotnet/runtime that referenced this pull request Nov 16, 2022
@sbomer
Bump cecil package version (dotnet/linker#2174)
84a2897 
* Bump cecil package version

The submodule update in dotnet/linker#2156
incremented the cecil version, but we were still using 0.11.3 as the version
in our package graph. See dotnet/linker#1515 for more
context on how this is set up.

Fixes dotnet/linker#2173

* Remove unnecessary cast

Commit migrated from dotnet/linker@0cb9250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vitek-karas vitek-karas vitek-karas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marek-safar @vitek-karas @sbomer